FSUI: Load all language fonts at all times #13589

TellowKrinkle · 2025-11-23T07:31:27Z

Description of Changes

Allow use of system fonts
Load all language fonts instead of just the one supported by the current locale
mmap fonts instead of copying them into memory
Enable non-English game titles in FSUI
Allow slightly wider title strings on horizontal FSUI buttons
Center icons in their buttons on the FSUI nav bar

Fixes #12804

Rationale behind Changes

No more prompts to download fonts when using non-latin languages unless your system is missing that font
Don't need to ship 25MB Noto Color Emoji on Windows (still needed on macOS and Linux)
Can use non-English game titles in FSUI
Non-English characters in paths render properly in FSUI
Save ~75MB of ram when using the 25MB Noto Color Emoji font

Suggested Testing Steps

Delete any downloaded fonts from your PCSX2 directory
Make sure you don't get prompted to download any fonts (unless on Linux and don't have Noto fonts)
Make sure non-English game titles render properly in FSUI
Make sure fonts look nice in your language in FSUI (Arabic is still broken, sorry)
Make sure line height looks reasonable everywhere in FSUI (lines shouldn't look like they're squished against each other)

Notes

Font sizes have changed for non-latin fonts. Translators will need to re-check FSUI to make sure their translations still fit.
Linux packagers should add Noto Sans {CJK, Arabic, Hebrew, Devanagari} to the recommended dependencies of their packages.

Did you use AI to help find, test, or implement this issue or feature?

No

pcsx2/ImGui/ImGuiManager.cpp

TheLastRar

translation.cpp needs to be formatted, any sections where you disagree with clang-format probably should have // clang-format off/on comments added.

I've not reviewed the added freetype code or the patches to imgui.

common/FileSystem.cpp

pcsx2-qt/Translations.cpp

pcsx2/ImGui/ImGuiFullscreen.cpp

TheLastRar · 2025-11-26T16:03:57Z

pcsx2/ImGui/ImGuiManager.h

-	void SetFontPath(std::string path);
+	struct FontInfo
+	{
+		std::span<const u8> data;
+		std::span<const u32> exclude_ranges;
+		const char* face_name;
+		bool is_emoji_font;
+	};
+
+	/// Sets a list of fonts to use.
+	void SetFonts(std::vector<FontInfo> info);



Given how we have to tread emoji fonts separately, would it make sense to pass those fonts as a second parameter instead of having to check is_emoji_font eveytime we iterate info?

Hopefully in the future we can treat emoji fonts less special, and it'll just be an is_emoji_font ? color : grayscale.

I'd like to keep them together.

Aside from the Glyph*AdvanceX setting, the main special treatment needed would be filtering the Variation Selector codepoints.
I'm suspecting that will probably be needed for as long as we use ImGui for text rendering.

Ahh true

I'd still like them together since it allows the font selection code to have minimal extra stuff to work around imgui's brokenness.

Side note, I'd like to get rid of the forced advance at some point, since it affects the spacing when used in normal text. If we want them to use a fixed amount of space when being used as icons, we should do that by separately rendering the icon and giving it a fixed amount of space, not by editing the font (which is shared by normal text rendering) to make it monospace.

I'd still like them together since it allows the font selection code to have minimal extra stuff to work around imgui's brokenness.

I guess it's a question where you think it's best to handle it.
I'm still inclined to think in translation is better, where you are already filtering the emoji font due to ImGui's broken bitmap and missing COLv1 support.
But I guess that is up to you.

Side note, I'd like to get rid of the forced advance at some point.

We should, outside of the settings interfaces I think there are a few other locations relying on forced advance, but outside the scope here.

I'm still inclined to think in translation is better, where you are already filtering the emoji font due to ImGui's broken bitmap and missing COLv1 support.

0001-FSUI-Separate-font-and-emoji-font-lists.patch

Is this what you were thinking? Because it doesn't really help specialize that filtering for only emoji fonts or anything.
(The filtering isn't even applied to all emoji fonts, since it wouldn't properly allow a non-SVG COLRv0 or B&W emoji font.)

I mentioned the filtering as more of an example of translations working around ImGui issues, rather then anything to be address. (It looks fine to me).

Your patch does look reasonable, when I to a poke at it I had looked at TryLoadFonts/DownloadFontIfMissing instead TheLastRar@122c5fb

Not a huge fan of either patch tbh, but I'd prefer mine if we have to use one

I guess it's fine

Maybe a 3rd opinion would serve as a deciding factor.

Protects against all the other stuff we load eating up all the address space that we want

pcsx2-qt/Translations.cpp

spaceage64 · 2025-12-06T11:47:21Z

I have a question: instead of relying on Noto Color Emoji, can’t it instead just take the OS’s color emoji font and work with that? Then there is no longer a need to include Noto just for some emojis.

TellowKrinkle · 2025-12-07T10:14:26Z

I have a question: instead of relying on Noto Color Emoji, can’t it instead just take the OS’s color emoji font and work with that? Then there is no longer a need to include Noto just for some emojis.

It does that on Windows.

Apple Color Emoji isn't currently renderable, since it's bitmap based, which isn't supported by imgui+Freetype.

Most Linux distros ship Noto Color Emoji, but it comes in Bitmap, SVG, and COLRv1 versions and SVG is the only one imgui supports. That's the biggest of the three, so most Linux distros do not ship it. Fedora recently switched from Bitmap to COLRv1, neither of which we can render.

TheLastRar

Had a quick look at the achievement FSUI and spacing looked okay.

Code changes look fine, Pending another reviewers opinion on #13589 (comment)

ocornut responded to your request ocornut/imgui#8857
Can you perhaps respond to them given it's relevance to your patch?

TellowKrinkle · 2025-12-09T01:19:36Z

Can you perhaps respond to them given it's relevance to your patch?

Done

github-actions bot added Build | Project System Dependencies Pull requests that update a dependency file GUI/Qt OSD / ImGui labels Nov 23, 2025

Mrlinkwii added the Needs Rebase label Nov 24, 2025

TellowKrinkle force-pushed the AllTheFonts branch from 47467db to 0422418 Compare November 25, 2025 03:48

TellowKrinkle removed the Needs Rebase label Nov 25, 2025

TheLastRar requested changes Nov 25, 2025

View reviewed changes

pcsx2/ImGui/ImGuiManager.cpp Show resolved Hide resolved

pcsx2/ImGui/ImGuiManager.cpp Show resolved Hide resolved

TellowKrinkle force-pushed the AllTheFonts branch 2 times, most recently from 2f63b04 to 03f7350 Compare November 26, 2025 04:36

TellowKrinkle requested a review from TheLastRar November 26, 2025 04:38

TheLastRar reviewed Nov 26, 2025

View reviewed changes

TellowKrinkle added 2 commits November 26, 2025 23:47

Add functions to map a file into the process

37900ad

Core: Reserve memory map as early as possible

a553345

Protects against all the other stuff we load eating up all the address space that we want

TellowKrinkle force-pushed the AllTheFonts branch 2 times, most recently from e35ef57 to b1ba002 Compare November 27, 2025 06:43

github-actions bot added the RetroAchievements label Nov 27, 2025

TellowKrinkle force-pushed the AllTheFonts branch from b1ba002 to c22d397 Compare November 27, 2025 06:56

Mrlinkwii approved these changes Nov 27, 2025

View reviewed changes

TellowKrinkle force-pushed the AllTheFonts branch 3 times, most recently from c716ff3 to 2618ccc Compare November 29, 2025 05:47

TheLastRar reviewed Nov 30, 2025

View reviewed changes

pcsx2-qt/Translations.cpp Show resolved Hide resolved

TellowKrinkle added 7 commits December 1, 2025 19:19

FSUI: Use system fonts when available

d6df1b9

imgui: Let caller handle memory management of font data

d99d567

imgui: Don't shrink fonts based on their line height

8f57c0b

FSUI: Adjust sizes to match new font sizes

f338ce6

FSUI: Give horizontal titles a bit more space

d70808d

CMake: Add option to skip installing Noto Color Emoji

81da49f

FSUI: Avoid needing two copies of every settings value query

9b87625

TellowKrinkle added 3 commits December 1, 2025 19:19

Host: Add RunOnGSThread helper

fa2abdd

FSUI: Support non-English game titles

a91d02f

FSUI: Use locale sensitive sort for game list

a228248

TellowKrinkle force-pushed the AllTheFonts branch from 2618ccc to a228248 Compare December 2, 2025 01:19

JordanTheToaster added this to the Release 2.8 milestone Dec 5, 2025

TheLastRar approved these changes Dec 8, 2025

View reviewed changes

TheLastRar added the Needs Rebase label Dec 10, 2025

Uh oh!

FSUI: Load all language fonts at all times #13589

Are you sure you want to change the base?

FSUI: Load all language fonts at all times #13589

Conversation

TellowKrinkle commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Changes

Rationale behind Changes

Suggested Testing Steps

Notes

Did you use AI to help find, test, or implement this issue or feature?

Uh oh!

Uh oh!

Uh oh!

TheLastRar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spaceage64 commented Dec 6, 2025

Uh oh!

TellowKrinkle commented Dec 7, 2025

Uh oh!

TheLastRar left a comment

Choose a reason for hiding this comment

Uh oh!

TellowKrinkle commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TellowKrinkle commented Nov 23, 2025 •

edited

Loading