Skip to content

GS/VK/GL/DX12/DX11: Improved accuracy for lines and AA1 support for lines/triangles. #13617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TJnotJT wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

GS/VK/GL/DX12/DX11: Improved accuracy for lines and AA1 support for lines/triangles. #13617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16a7cfe
GS/VK/GL/DX12/DX11: Implement accurate drawing/AA1 for lines and tria…
TJnotJT Nov 7, 2025
cbd4a9c
GS/VK/GL/DX12/DX11: Use default buffer instead of upload buffer for a…
TJnotJT Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
334 changes: 324 additions & 10 deletions bin/resources/shaders/dx11/tfx.fx
View file
Open in desktop

Large diffs are not rendered by default.

355 changes: 338 additions & 17 deletions bin/resources/shaders/opengl/tfx_fs.glsl
View file
Open in desktop

Large diffs are not rendered by default.

34 changes: 34 additions & 0 deletions bin/resources/shaders/opengl/tfx_vgs.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,16 @@

//#version 420 // Keep it for text editor detection

#define ACCURATE_LINES 1
#define ACCURATE_TRIANGLES 2

#if VS_ACCURATE_PRIMS
flat out uint accurate_prims_index;
#if VS_ACCURATE_PRIMS == ACCURATE_TRIANGLES
flat out uint accurate_triangles_interior;
#endif
#endif

layout(std140, binding = 1) uniform cb20
{
vec2 VertexScale;
Expand All @@ -14,6 +24,8 @@ layout(std140, binding = 1) uniform cb20
vec2 PointSize;
uint MaxDepth;
uint pad_cb20;
uint BaseVertex;
uint pad_cb20_2;
};

#ifdef VERTEX_SHADER
Expand Down Expand Up @@ -75,6 +87,28 @@ void vs_main()
gl_Position.z = float(z) * exp_min32;
gl_Position.w = 1.0f;

#if VS_ACCURATE_PRIMS == ACCURATE_LINES
accurate_prims_index = (gl_VertexID - BaseVertex) / 6;
VSout.t_float = vec4(0.0f);
VSout.t_int = vec4(0.0f);
VSout.c = vec4(0.0f);
return; // Don't send line vertex attributes - they are interpolated manually in the fragment shader.
#elif VS_ACCURATE_PRIMS == ACCURATE_TRIANGLES
uint vertex_id = gl_VertexID - BaseVertex;
uint prim_id = vertex_id / 21;
accurate_triangles_interior = uint((vertex_id - 21 * prim_id) < 3); // First 3 vertices in each group of 21 is interior.
if (!bool(accurate_triangles_interior))
{
uint edge = (vertex_id - 21 * prim_id - 3) / 6; // Each group of 6 vertices after first 3 is one edge.
accurate_prims_index = 3 * prim_id + edge;
VSout.t_float = vec4(0.0f);
VSout.t_int = vec4(0.0f);
VSout.c = vec4(0.0f);
return; // Don't send edge vertex attributes - they are interpolated manually in the fragment shader.
}
// Send the interior vertex attributes for fixed function interpolation.
#endif

texture_coord();

VSout.c = i_c;
Expand Down
Loading