GS/HW: Allow swapping indices to handle provoking vertex first APIs.#13672
Draft
TJnotJT wants to merge 2 commits intoPCSX2:masterfrom
Draft
GS/HW: Allow swapping indices to handle provoking vertex first APIs.#13672TJnotJT wants to merge 2 commits intoPCSX2:masterfrom
TJnotJT wants to merge 2 commits intoPCSX2:masterfrom
Conversation
Contributor
|
Fixes a regression with d136b homebrew that got introduced with #12986 |
Contributor
Author
That's good to know, just saw the related discussion on Discord. |
TJnotJT
force-pushed
the
gs-provoking-first-swap-index
branch
from
c7f1eae to
4975bcf
Compare
Avoids doing an extra copy of the whole vertex queue when its not needed. Approach suggested by TellowKrinkle.
TJnotJT
force-pushed
the
gs-provoking-first-swap-index
branch
from
4975bcf to
53d3b7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Draft until dump run on DX completed.
Description of Changes
Rationale behind Changes
Avoids doing an extra copy of the whole vertex queue when its not needed.
Suggested Testing Steps
Testing DX11 and/or DX12 on a variety of games would be helpful.
Did you use AI to help find, test, or implement this issue or feature?
No.
Credits
Approach suggested by TellowKrinkle.