Skip to content

Conversation

@SilentHeII
Copy link

@SilentHeII SilentHeII commented Dec 14, 2025

Description of Changes

You are able to obtain extra ingame items if you have a save file from Shadow Hearts 1.

I also added filters for Biohazard Outbreak 1 and 2 to account for network configuration files.

Suggested Testing Steps

Add Geppetto's apartment in Paris, you obtain additional items MR. SOMMELIER and MR.
MATADOR.

Did you use AI to help find, test, or implement this issue or feature?

No.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@SilentHeII SilentHeII changed the title Adds memcardFilters for Shadow Hearts: Covenant GameIndex.yaml - Add memcardFilters for Shadow Hearts: Covenant Dec 14, 2025
Comment on lines 58832 to 58834
memcardFilters: # Reads Shadow Hearts for extra items.
- "SLPS-25041"
- "SLPS-73418"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect indenting

Comment on lines 69318 to 69319
memcardFilters: # Reads Shadow Hearts for extra items.
- "SLUS-20347"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect indenting

Comment on lines 69338 to 69340
memcardFilters: # Reads Shadow Hearts for extra items.
- "SLUS-21041"
- "SLUS-20347"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect indenting

@SilentHeII SilentHeII changed the title GameIndex.yaml - Add memcardFilters for Shadow Hearts: Covenant GameIndex.yaml - Add memcardFilters for a small handful of games Dec 14, 2025
@JordanTheToaster
Copy link
Member

Can you squash your commits and prefix it with GameDB:

Reads Twisted Metal Black for bonus unlockable.

Adds memcardFilters for Shadow Hearts: Covenant

Ignore my previous pull request. I have no idea why it formatted it so obnoxiously.

Anyway, you get extra ingame items if you have a save file from Shadow Hearts 1.

GameIndex changes

Added memcardFilters for Biohazard Outbreak & Biohazard Outbreak File 2 to allow for creation of network configurations.

Added missing titles

Added missing titles to allow games to load their own saves.
@lightningterror
Copy link
Contributor

I also added filters for Biohazard Outbreak 1 and 2 to account for network configuration files.

Can you explain why the network configuration files are added in memory card filters since that's an unusual place to put them?

@SilentHeII
Copy link
Author

I don't think I understand your question?
The network configurations are stored as save files. You are unable to create a network configuration or store previous used settings without those filters, preventing you from playing online.

@lightningterror lightningterror changed the title GameIndex.yaml - Add memcardFilters for a small handful of games GameDB: Add memcardFilters for a small handful of games Jan 6, 2026
Copy link
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks good, and seems that the network config filter is needed.

@lightningterror lightningterror merged commit 0f82503 into PCSX2:master Jan 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants