-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
GameDB: Add memcardFilters for a small handful of games #13702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
bin/resources/GameIndex.yaml
Outdated
| memcardFilters: # Reads Shadow Hearts for extra items. | ||
| - "SLPS-25041" | ||
| - "SLPS-73418" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect indenting
bin/resources/GameIndex.yaml
Outdated
| memcardFilters: # Reads Shadow Hearts for extra items. | ||
| - "SLUS-20347" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect indenting
bin/resources/GameIndex.yaml
Outdated
| memcardFilters: # Reads Shadow Hearts for extra items. | ||
| - "SLUS-21041" | ||
| - "SLUS-20347" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect indenting
|
Can you squash your commits and prefix it with GameDB: |
Reads Twisted Metal Black for bonus unlockable. Adds memcardFilters for Shadow Hearts: Covenant Ignore my previous pull request. I have no idea why it formatted it so obnoxiously. Anyway, you get extra ingame items if you have a save file from Shadow Hearts 1. GameIndex changes Added memcardFilters for Biohazard Outbreak & Biohazard Outbreak File 2 to allow for creation of network configurations. Added missing titles Added missing titles to allow games to load their own saves.
Can you explain why the network configuration files are added in memory card filters since that's an unusual place to put them? |
|
I don't think I understand your question? |
lightningterror
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting looks good, and seems that the network config filter is needed.
Description of Changes
You are able to obtain extra ingame items if you have a save file from Shadow Hearts 1.
I also added filters for Biohazard Outbreak 1 and 2 to account for network configuration files.
Suggested Testing Steps
Add Geppetto's apartment in Paris, you obtain additional items MR. SOMMELIER and MR.
MATADOR.
Did you use AI to help find, test, or implement this issue or feature?
No.