-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Deps: Update SDL3 to v3.4.0 #13764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps: Update SDL3 to v3.4.0 #13764
Conversation
|
This PR breaks Hotplug of Dual Sense controllers, uncovered while looking into root cause for Dolphin https://github.com/dolphin-emu/dolphin/pull/13982/files |
|
Linking SDL issue for completeness. libsdl-org/SDL#14802 |
|
Just a heads up, I may update that issue since it may not be related to the HINT after all? PCSX2 is strange because it is detecting the controller sometimes, but not consistently like prior builds. Where as for Dolphin it only seems to be broken with that HINT set. Though to be fair, I haven't extensively tested SDL 3.4.0 on Dolphin with it off... |
|
I have reproduced it 0 times on the flatpak, with the hint set or not. (Over 20 hotplugs). It's weird its not consistent behavior. |
You can build the windows deps using the script in |
f32772a to
845bce0
Compare
|
@refractionpcsx2 I just tested extensively again now on: I think the AppImage not picking it up the few times was unrelated as I've been unable to reproduce it since. You're probably fine to merge this, and see if anyone else runs into this bug. |
SternXD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
controllers/audio still work fine

Description of Changes
Updates SDL3 from v3.2.26 to v3.4.0.
Rationale behind Changes
Bug fixes new controller support and FFB fixes are all nice to have.
Suggested Testing Steps
Make sure all the usual SDL things work as expected and also check ffmpeg HEVC recording on Linux as that seemed to fail a test for some unknown reason.
Did you use AI to help find, test, or implement this issue or feature?
No