Skip to content

Conversation

@JordanTheToaster
Copy link
Member

Description of Changes

Updates SDL3 from v3.2.26 to v3.4.0.

Rationale behind Changes

Bug fixes new controller support and FFB fixes are all nice to have.

Suggested Testing Steps

Make sure all the usual SDL things work as expected and also check ffmpeg HEVC recording on Linux as that seemed to fail a test for some unknown reason.

Did you use AI to help find, test, or implement this issue or feature?

No

@dreamsyntax
Copy link
Contributor

dreamsyntax commented Jan 10, 2026

This PR breaks Hotplug of Dual Sense controllers, uncovered while looking into root cause for Dolphin https://github.com/dolphin-emu/dolphin/pull/13982/files
Interestingly the AppImage directly from CI (without the presumed problematic HINT set at all) can also run into the issue
image

@refractionpcsx2
Copy link
Member

Linking SDL issue for completeness. libsdl-org/SDL#14802

@dreamsyntax
Copy link
Contributor

dreamsyntax commented Jan 10, 2026

Just a heads up, I may update that issue since it may not be related to the HINT after all? PCSX2 is strange because it is detecting the controller sometimes, but not consistently like prior builds. Where as for Dolphin it only seems to be broken with that HINT set. Though to be fair, I haven't extensively tested SDL 3.4.0 on Dolphin with it off...

@dreamsyntax
Copy link
Contributor

dreamsyntax commented Jan 10, 2026

I have reproduced it 0 times on the flatpak, with the hint set or not. (Over 20 hotplugs).
Is the builder for flatpak really building with SDL 3.4.0? Is there a way i can verify?
Update: I also tested with Dolphin's 2512 flatpak - not reproducible surprisingly.

It's weird its not consistent behavior.
Side note, could someone upload the deps bundle that this PR would push, so I can batch test on Windows?

@TheLastRar
Copy link
Contributor

TheLastRar commented Jan 10, 2026

Side note, could someone upload the deps bundle that this PR would push, so I can batch test on Windows?

You can build the windows deps using the script in /.github/workflows/scripts/windows/build-dependencies.bat

@dreamsyntax
Copy link
Contributor

dreamsyntax commented Jan 11, 2026

@refractionpcsx2 I just tested extensively again now on:
Windows (built manually with latest 845bce0 and built deps using above script) - 40/40
AppImage - 40/40
flatpak - 40/40

I think the AppImage not picking it up the few times was unrelated as I've been unable to reproduce it since.

You're probably fine to merge this, and see if anyone else runs into this bug.
Seems its a Dolphin issue and the AppImage case was a fluke

Copy link
Contributor

@SternXD SternXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controllers/audio still work fine

@lightningterror lightningterror merged commit 293b60a into PCSX2:master Jan 12, 2026
12 checks passed
@JordanTheToaster JordanTheToaster deleted the beegupdate branch January 12, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants