GS: Add utility functions for vertices/quads.#14240
Open
TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
Open
GS: Add utility functions for vertices/quads.#14240TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
Conversation
Mrlinkwii
approved these changes
Apr 4, 2026
Contributor
Mrlinkwii
left a comment
Mrlinkwii
left a comment
There was a problem hiding this comment.
smoke test was fine on linux on HW renderers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add utility functions for vertices/quads:
Rationale behind Changes
To reduce code duplication and organize commonly used functionality.
Different parts of the renderers reimplement some of this functionality (e.g. triangles-as-quads detection and overlap draw list computation), so they could be refactored to use these functions.
Suggested Testing Steps
Currently, none of the functions are used, so they could be just checked for correctness.
I've done a few ad hoc tests to make sure they behave as expected.
Did you use AI to help find, test, or implement this issue or feature?
No.