Debugger: Merge redundant memory interfaces#14257
Open
chaoticgd wants to merge 1 commit intoPCSX2:masterfrom
Open
Debugger: Merge redundant memory interfaces#14257chaoticgd wants to merge 1 commit intoPCSX2:masterfrom
chaoticgd wants to merge 1 commit intoPCSX2:masterfrom
Conversation
chaoticgd
force-pushed
the
sharing_the_memory_interface
branch
2 times, most recently
from
5a06219 to
766ebb2
Compare
chaoticgd
force-pushed
the
sharing_the_memory_interface
branch
from
766ebb2 to
9a0ff92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Remove MemoryReader, and replace all usages of it with MemoryInterface.
Rationale behind Changes
Less duplication. Also make it so R3000DebugInterface::Read64 sets its valid out parameter properly.
I've removed some alignment checks that seem to no longer be required now that we're using vtlb_memSafeReadBytes.
Suggested Testing Steps
Try parts of the debugger that access memory, make sure they still work.
Did you use AI to help find, test, or implement this issue or feature?
No.