Achievement: Fix default custom sound effect behavior#14269
Open
kamfretoz wants to merge 2 commits intoPCSX2:masterfrom
Open
Achievement: Fix default custom sound effect behavior#14269kamfretoz wants to merge 2 commits intoPCSX2:masterfrom
kamfretoz wants to merge 2 commits intoPCSX2:masterfrom
Conversation
kamfretoz
force-pushed
the
achievement-sound
branch
3 times, most recently
from
1b813c7 to
a33ee12
Compare
Achievements: Preview custom sounds directly instead of using/opening the system's default audio player.
kamfretoz
force-pushed
the
achievement-sound
branch
from
a33ee12 to
c6305a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR mainly fixes the bug manifesting on AppImage where the default notification sound for the appimage only works on the first session of a fresh install, any subsequent run wont play any sound due to how i saved the path on fresh install (and because AppImage's app resources are ephemeral and uses different path on every single launch).
And also clicking on the preview button now directly plays the sound instead of opening the user's default audio player installed on their system.
Rationale behind Changes
the first one was a bug. And as for the 2nd, i accidentally got my main music playlist on AIMP wiped because for whatever god forsaken reason, if i already have a playlist and then decided to open a random audio file, it wipes my existing playlist clean.
Suggested Testing Steps
Make sure nothing is broken on windows.
On AppImage, start with a fresh install, login to RCheevos, start a game and observe the notification still works. Now exit PCSX2 and reopen the appimage, start a game and the default notification sound should still works.
Did you use AI to help find, test, or implement this issue or feature?
Gak