GS/HW: Disable HalfPixelOffset and ForceEvenSpritePosition on texture shuffles.#14283
Open
TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
Open
GS/HW: Disable HalfPixelOffset and ForceEvenSpritePosition on texture shuffles.#14283TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
TJnotJT wants to merge 1 commit intoPCSX2:masterfrom
Conversation
TJnotJT
force-pushed
the
gs-fix-hpo-shuffle
branch
from
4e33338 to
183981c
Compare
JordanTheToaster
approved these changes
Apr 11, 2026
TJnotJT
force-pushed
the
gs-fix-hpo-shuffle
branch
from
183981c to
9d08ca3
Compare
Quad conversion in texture shuffles is already aligned and not intended to interact with upscaling coord fixes.
JordanTheToaster
approved these changes
Apr 11, 2026
TJnotJT
force-pushed
the
gs-fix-hpo-shuffle
branch
from
9d08ca3 to
98f6cfe
Compare
Contributor
Author
|
Last push disables HPO for XY (before only had it for UV) and force even sprite position for texture shuffles. Appears to fix the issues in question, and reduce artifacts in a few other dumps with upscaling. Added some misc. cleanup/logging to texture shuffle code. |
TJnotJT
changed the title
TJnotJT
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Disable UserHacks_HalfPixelOffset and UserHacks_ForceEvenSpritePosition on texture shuffle draws. Applies to upscaling only.
Rationale behind Changes
Fixes a regression from #14259.
The quad conversion in texture shuffles already aligns the coordinates, so adding a HPO or even sprite position may misalign it.
Suggested Testing Steps
Try games with texture shuffles on a HW renderer with upscaling. An example dump from Sly 2 is attached.
Sly_2_-_Band_of_Thieves_SCUS-97316_20240110145658.gs.xz.zip
Master 2x
PR 2x
Did you use AI to help find, test, or implement this issue or feature?
No.