Skip to content

Conversation

@sebapersson
Copy link
Contributor

Adding test-case with non-zero start-time. Unlike test-case 0018 this does not have pre-equilibration.

Arguably this test-case should come before 0018 as it should be easier for importers to pass, but I believe sorting the test-cases in terms of difficulty should be a later PR.

Added as 0029, so it can be merged after #105.

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Arguably this test-case should come before 0018 as it should be easier for importers to pass, but I believe sorting the test-cases in terms of difficulty should be a later PR.

That was also my plan at some point, but I think it's hard to maintain. Also, the difficulty might be somewhat simulator-dependent.
I am happy to see them sorted, but I think just adding a comment like "this is a more tricky version of XYZ" might also do the job.

@sebapersson
Copy link
Contributor Author

I am happy to see them sorted, but I think just adding a comment like "this is a more tricky version of XYZ" might also do the job.

I think this is a good suggestion, as indeed how hard a test-case is depends very much on the importer. I have added a short text in 0018 referring to 0029.

@dweindl dweindl merged commit 2742279 into PEtab-dev:main Dec 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants