-
Notifications
You must be signed in to change notification settings - Fork 3
Test case with non zero start time #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dweindl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Arguably this test-case should come before 0018 as it should be easier for importers to pass, but I believe sorting the test-cases in terms of difficulty should be a later PR.
That was also my plan at some point, but I think it's hard to maintain. Also, the difficulty might be somewhat simulator-dependent.
I am happy to see them sorted, but I think just adding a comment like "this is a more tricky version of XYZ" might also do the job.
I think this is a good suggestion, as indeed how hard a test-case is depends very much on the importer. I have added a short text in 0018 referring to 0029. |
Adding test-case with non-zero start-time. Unlike test-case
0018this does not have pre-equilibration.Arguably this test-case should come before
0018as it should be easier for importers to pass, but I believe sorting the test-cases in terms of difficulty should be a later PR.Added as
0029, so it can be merged after #105.