Closed
Conversation
Member
Author
|
@Toxantron was this something you still wanted to go through with or was it neglected for a reason? 🤔 |
Contributor
|
Would like to, especially now in one repo. |
Member
|
I have another one:
void RequestLastError();
void RequestLastWarning();
event EventHandler<NotificationResponse> ErrorOccured;
event EventHandler<NotificationResponse> WarningOccured;.. are always not implemented in my laser drivers (Foba, ACI) - it was just for an implementation of a specific manufacturer. Errors/Warnings should always be a response of the actions (Mark, SetMArkingFile) - other state changes should be raised by the driver-state-change. Are there other votes for removal? |
Contributor
|
We should consider TPL API for those and others. The could return warnings or exceptions that way as well. |
Member
|
closed after consent described here: #765 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.