Conversation
|
Consens after discussion with @1nf0rmagician
|
38d5561 to
f5ff590
Compare
|
@1nf0rmagician I have not used the
Using custom result objects breaks this natural flow and requires extra boilerplate. Developers might forget to check Success, leading to subtle bugs. Exceptions force attention because unhandled exceptions bubble up and fail fast. I will change that for all driver APIs. |
|
@1nf0rmagician TODOs but not part of this Pull-Request #784 #785 #786 |
|
@dbeuchler and @1nf0rmagician sorry for not being aus involved recently as I planned to. Could you eloborate why you keep the generic interfaces? Given the little benefit and the import regarding proxies, I don't fully understand your decision. |
We inherited the IWeightScaleDriver, IRfidDriver from IInputDriver to use it in a more generic way but with typed payloads. Removing the type from the payload would lead to more and more casting and abstraction to the lowest level. At the moment we do not need this level of abstraction and keep the typed interfaces. Do you have additional arguments why to remove the type? Do we overlook something? |
Things for MORYX 10:
IMarkingLaserDriverand remove unused stuff (Warning/Error-events+requests)Points for discussion