Polyfills 8.4/8.5: remove overzealous exclusion #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I already annotated when I added these attribute related exclusions that they weren't targeted enough and ran the risk of blanket ignoring more than we should. I've now decided to remove these as the excludes are too risky, meaning that end-users may end up missing legitimate PHP cross-version compatibility issues because of it. This highlights that more needs to change in how attributes are detected and flagged in PHPCompatibility itself. Once that improvement is made, these tests should be re-enabled and more targeted excludes should be added. Also see 74, which I have opened as a follow-up to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already annotated when I added these attribute related exclusions that they weren't targeted enough and ran the risk of blanket ignoring more than we should.
I've now decided to remove these as the excludes are too risky, meaning that end-users may end up missing legitimate PHP cross-version compatibility issues because of it.
This highlights that more needs to change in how attributes are detected and flagged in PHPCompatibility itself. Once that improvement is made, these tests should be re-enabled and more targeted excludes should be added.
Also see #74, which I have opened as a follow-up to this PR.