Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@
<!--
Detection for the Deprecated attribute is incomplete in PHPCompatibility 10.0.0-alpha1.
Handling for this should be added once the detection implementation is known.
The following exclude is a temporary placeholder, which should be removed as soon as
possible as it will ignore too much.
-->
<exclude name="PHPCompatibility.Attributes.NewAttributes.PHPStormAttributeFound"/>

<exclude name="PHPCompatibility.Classes.NewClasses.reflectionconstantFound"/>
</rule>
Expand Down
3 changes: 0 additions & 3 deletions PHPCompatibilitySymfonyPolyfillPHP85/ruleset.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,7 @@
<!--
Detection for the DelayedTargetValidation and NoDiscard attributes is incomplete in PHPCompatibility 10.0.0-alpha1.
This section should be filled out once the detection implementation is known.
The following exclude is a temporary placeholder, which should be removed as soon as
possible as it will ignore too much.
-->
<exclude name="PHPCompatibility.Attributes.NewAttributes.Found"/>
</rule>

<!-- Prevent false positives being thrown when run over the code of polyfill-php84 itself. -->
Expand Down
4 changes: 4 additions & 0 deletions Test/SymfonyPolyfillPHP84Test.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,9 @@

$r = new ReflectionConstant(ClassName::CONSTANT_NAME);

/*
// This test will not help at this time as we can't just ignore the use of the Deprecated attribute
// with the current attribute handling in PHPCompatibility 10.0.
#[Deprecated]
function foo() {}
*/
4 changes: 4 additions & 0 deletions Test/SymfonyPolyfillPHP85Test.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
array_first($array);
array_last($array);

/*
// This test will not help at this time as we can't just ignore the use of the DelayedTargetValidation/NoDiscard attribute
// with the current attribute handling in PHPCompatibility 10.0.
#[DelayedTargetValidation]
#[NoDiscard]
function dummy() {}
*/