Set writeAttribute return type #2776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
force-pushed
the
writeAttribute
branch
from
947a949 to
1ab2357
Compare
Progi1984
reviewed
Jun 5, 2025
Progi1984
reviewed
Jun 5, 2025
There was a problem hiding this comment.
@radarhere Hi,
Could you rebase your PR and update the changelog file (docs/changes/1.x/1.5.0.md), please ?
Progi1984
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2204. Uses the
writeAttribute()return type documented at https://www.php.net/manual/en/xmlwriter.writeattribute.phpChecklist:
My CI is mostly green - it unrelatedly complains about loripsum.net being down - https://github.com/radarhere/PHPWord/actions/runs/14656574578
This specific method isn't mentioned in the docs.
Since #2239 didn't seem to be significant enough for the changelog, I don't expect this is either.