Skip to content

Set cmake_minimum_required to 3.5#355

Merged
PJK merged 1 commit intomasterfrom
cmake-version
Apr 4, 2025
Merged

Set cmake_minimum_required to 3.5#355
PJK merged 1 commit intomasterfrom
cmake-version

Conversation

@PJK
Copy link
Owner

@PJK PJK commented Apr 4, 2025

Fixed #351

Description

What changes and why

Checklist

  • I have read followed CONTRIBUTING.md
    • I have added tests
    • I have updated the documentation
    • I have updated the CHANGELOG
  • Are there any breaking changes?
    • If yes: I have marked them in the CHANGELOG (example)
  • Does this PR introduce any platform specific code?
  • Security: Does this PR potentially affect security?
  • Performance: Does this PR potentially affect performance?

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (54a3623) to head (1183292).
Report is 28 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files          20       20           
  Lines        1684     1684           
=======================================
  Hits         1660     1660           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PJK PJK merged commit 9b4b00c into master Apr 4, 2025
18 checks passed
@PJK PJK deleted the cmake-version branch April 4, 2025 21:32
PJK added a commit that referenced this pull request Aug 30, 2025
PJK added a commit that referenced this pull request Aug 30, 2025
@PJK PJK mentioned this pull request Feb 8, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails to build with CMake 4.0

2 participants