Arduino Matrix Portal ESP32-s3 support added#127
Conversation
mkalkbrenner
left a comment
There was a problem hiding this comment.
format the code with clang
src/transports/usb_transport.cpp
Outdated
| #else | ||
| Serial.setRxBufferSize(usbPackageSize + 128); | ||
| Serial.setTxBufferSize(64); | ||
| Serial.setRxBufferSize(64); |
There was a problem hiding this comment.
Don't overwrite the previous line
src/transports/wifi_transport.cpp
Outdated
| GetDisplayDriver()->DisplayText("zedmd-wifi.local", 0, TOTAL_HEIGHT - 5, 0, 0, | ||
| 0, true); | ||
|
|
||
| Serial.print("Start webserver "); |
There was a problem hiding this comment.
Don't print debug messages over the serial interface.
Same for following Serial.print commands.
src/main.cpp
Outdated
| return 0; | ||
| } | ||
|
|
||
| void PrintFileSystem(fs::FS &fs, const char * dirname, uint8_t depth) { |
platformio.ini
Outdated
| ;debug_tool = esp-builtin | ||
| ;debug_init_break = tbreak setup | ||
| ;build_type = debug | ||
| monitor_port = COM8 |
platformio.ini
Outdated
| ;debug_init_break = tbreak setup | ||
| ;build_type = debug | ||
| monitor_port = COM8 | ||
| upload_port = COM9 |
platformio.ini
Outdated
| ;build_type = debug | ||
| monitor_port = COM8 | ||
| upload_port = COM9 | ||
| monitor_speed = 115200 |
platformio.ini
Outdated
| -DDISPLAY_LED_MATRIX=1 | ||
| -DARDUINO_ADAFRUIT_MATRIXPORTAL_ESP32S3=1 | ||
| -DPIXEL_COLOR_DEPTH_BITS=8 | ||
| -DZEDMD_WIFI_ONLY=1 No newline at end of file |
There was a problem hiding this comment.
Is it really WiFi only? Why is USB not supported?
There was a problem hiding this comment.
wrong setting, USB support is now included.
mkalkbrenner
left a comment
There was a problem hiding this comment.
Thanks for your work on this. We are close.
|
|
||
| [platformio] | ||
| default_envs = S3-N16R8_128x32 | ||
| default_envs = MatrixPortalS3_128x32 |
| framework = arduino | ||
| platform = https://github.com/pioarduino/platform-espressif32/releases/download/stable/platform-espressif32.zip | ||
| ;platform = https://github.com/pioarduino/platform-espressif32/releases/download/stable/platform-espressif32.zip | ||
| platform = https://github.com/pioarduino/platform-espressif32/releases/download/55.03.37/platform-espressif32.zip |
There was a problem hiding this comment.
Is that really required?
We build on github and it doesn't cache, so stable will always pull the latest stable.
| #ifdef BOARD_HAS_PSRAM | ||
| buffers[i] = (uint8_t *)heap_caps_malloc( | ||
| BUFFER_SIZE, MALLOC_CAP_SPIRAM | MALLOC_CAP_32BIT); | ||
|
|
| #endif | ||
|
|
||
| pinMode(FORWARD_BUTTON_PIN, INPUT_PULLUP); | ||
|
|
|
|
||
| // Serve index.html | ||
| server->on("/", HTTP_GET, [](AsyncWebServerRequest* request) { | ||
|
|
| #if defined(DISPLAY_LED_MATRIX) && defined(ESP_BUILD) | ||
|
|
||
| #include "Esp32LedMatrix.h" | ||
| #include <HardwareSerial.h> |
There was a problem hiding this comment.
I think that this include could be removed.
Summary
Add support for the Adafruit Matrix Portal ESP32-S3 board.
Changes
Motivation
This allows the project to run on the Adafruit Matrix Portal ESP32-S3, enabling users to use this board with the existing functionality.
Testing
Notes
During testing, filesystem uploads to ESP32 repeatedly failed with the default partitions configuration. Decreasing the partitions size to 6 MB resolved the issue.
If maintainers prefer a different naming convention or configuration structure for new boards, I am happy to adjust the implementation.