Skip to content

add editor role to people#1456

Merged
brandonhundt merged 1 commit intomainfrom
feat/person-tag-add-editor
Mar 23, 2026
Merged

add editor role to people#1456
brandonhundt merged 1 commit intomainfrom
feat/person-tag-add-editor

Conversation

@brandonhundt
Copy link
Copy Markdown
Contributor

closes #1455

  • add editor role to podcast:person tag

@brandonhundt brandonhundt requested a review from cavis March 20, 2026 20:19
Copy link
Copy Markdown
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question on ordering, but looks good.

@@ -1,5 +1,5 @@
class Person < ApplicationRecord
enum :role, %w[host producer guest].to_enum_h, prefix: true, allow_nil: true
enum :role, %w[editor host producer guest].to_enum_h, prefix: true, allow_nil: true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sort order, so will put "Editor" first in the dropdown - is that your intention?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if order matters much with only 4 options - alphabetical? add this at the end?
If I were to guess at the usage, I would guess host is only on the podcast, not specified on each episode unless it is a different host for one episode.
So, %w[guest host producer editor]? Whaddya think B?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went alphabetical, because it was naturally in alphabetical order. But yea, I hear this. Because its on both the Podcast & Episode I might suggest:

[host producer editor guest]

@brandonhundt brandonhundt merged commit 8002a1e into main Mar 23, 2026
3 checks passed
@brandonhundt brandonhundt deleted the feat/person-tag-add-editor branch March 23, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add editor as an option for the People tag

3 participants