Skip to content

add editor role to people #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandonhundt merged 1 commit into from
Mar 23, 2026
Merged

add editor role to people #1456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/person.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class Person < ApplicationRecord
enum :role, %w[host producer guest].to_enum_h, prefix: true, allow_nil: true
enum :role, %w[editor host producer guest].to_enum_h, prefix: true, allow_nil: true
Copy link
Copy Markdown
Member

@cavis cavis Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sort order, so will put "Editor" first in the dropdown - is that your intention?

Copy link
Copy Markdown
Member

@kookster kookster Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if order matters much with only 4 options - alphabetical? add this at the end?
If I were to guess at the usage, I would guess host is only on the podcast, not specified on each episode unless it is a different host for one episode.
So, %w[guest host producer editor]? Whaddya think B?

Copy link
Copy Markdown
Contributor Author

@brandonhundt brandonhundt Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went alphabetical, because it was naturally in alphabetical order. But yea, I hear this. Because its on both the Podcast & Episode I might suggest:

[host producer editor guest]


belongs_to :owner, -> { with_deleted }, polymorphic: true, optional: true, touch: true

Expand Down
1 change: 1 addition & 0 deletions config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,7 @@ en:
organization: Organization
role: Role
roles:
editor: Editor
guest: Guest
host: Host
producer: Producer
Expand Down
Loading