chore(rcS posix): move env var param override after airframe selection #26193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…selection Signed-off-by: Beniamino Pozzan <[email protected]>
farhangnaderi
approved these changes
Jan 2, 2026
Contributor
farhangnaderi
left a comment
farhangnaderi
left a comment
There was a problem hiding this comment.
Seems ok to me! @MaEtUgR might have an input though!
Member
|
If I understand correctly, the idea is to keep the override even if airframe has been changed, correct? |
dakejahl
approved these changes
Jan 6, 2026
Contributor
dakejahl
left a comment
dakejahl
left a comment
There was a problem hiding this comment.
I didn't even know this was a thing
Member
Author
@Pedro-Roque the idea is to let parameter override have higher priority than any other parameter change source in the posix startup sequence. So yes, it will keep the override even if airframe has been changed but that is just a side effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current poxix param override logic through env var is excecuter before the vehicle airframe is selected, therefore if the airframe defines custom parameter values, then the overrides will be ignored.
For example one cannot override
NAV_DLL_ACTwhen running gz_x500 sim as that parameter is set inPX4-Autopilot/ROMFS/px4fmu_common/init.d-posix/airframes/4001_gz_x500
Line 51 in 9df0ced
This PR moves the override logic after the airframe selection so that you can override any parameter.