Fixed Wing Loiter Modes - Orbit and Figure 8 #26194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishwillee
commented
Jan 2, 2026
hamishwillee
commented
Jan 2, 2026
hamishwillee
commented
Jan 2, 2026
2 tasks
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/enabling-the-figure-of-eight-mode/48081/9 |
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: https://discuss.px4.io/t/enabling-the-figure-of-eight-mode/48081/12 |
ttechnick
reviewed
Jan 7, 2026
ttechnick
requested changes
Jan 7, 2026
hamishwillee
commented
Jan 8, 2026
hamishwillee
commented
Jan 8, 2026
Contributor
Author
|
This should be ready for another review thanks @ttechnick |
ttechnick
reviewed
Jan 8, 2026
hamishwillee
commented
Jan 9, 2026
|
No flaws found |
Contributor
Author
|
Thanks very much @ttechnick - really appreciate the help. I'm going to merge now as I'm away two weeks, and this is good stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following question in https://discuss.px4.io/t/enabling-the-figure-of-eight-mode/48081/8 this adds docs for
Testing shows that figure 8 and orbit loiter are implemented as loiter modes within hold mode on FW, and not as distinct modes such as Orbit mode in MC.
As such, this is implemented as a "Loiter modes" section under the FW Hold mode doc.
There are questions about the implementation inline.
Note also that we need a QGC implementation. Issue for that is in mavlink/qgroundcontrol#12778