Add uxrce dds flow control flag #26209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No flaws found |
dakejahl
requested changes
Jan 6, 2026
Contributor
dakejahl
left a comment
dakejahl
left a comment
There was a problem hiding this comment.
The parameter reference docs are autogenerated. Also the addition to the baseboard docs is unnecessary since the parameter already defaults to 0, but might worth specifying anyway that it should be zero. Otherwise looks good to me.
hamishwillee
reviewed
Jan 7, 2026
hamishwillee
reviewed
Jan 7, 2026
hamishwillee
reviewed
Jan 7, 2026
hamishwillee
previously approved these changes
Jan 7, 2026
Contributor
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
Thanks @minotico . See https://github.com/PX4/PX4-Autopilot/pull/26209/files#r2670288009, but otherwise looks good to me. @dakejahl leaving for you to merge if you are happy.
dakejahl
previously approved these changes
Jan 8, 2026
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
dakejahl
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
Fixes #25973
Solution
Introduced parameter UXRCE_DDS_FLCTRL
Changelog Entry
For release notes:
Alternatives
None
Test coverage
Hardware pixhawk 6c mini for px4-ros2-interface-lib
Context
provided in issue mentioned above.