Added support for colored navigation lights and hybrid light functions.#26513
Open
Claudio-Chies wants to merge 2 commits intomainfrom
Open
Added support for colored navigation lights and hybrid light functions.#26513Claudio-Chies wants to merge 2 commits intomainfrom
Claudio-Chies wants to merge 2 commits intomainfrom
Conversation
|
No broken links found in changed files. |
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 192 byte (0.01 %)]px4_fmu-v6x [Total VM Diff: 8 byte (0 %)]Updated: 2026-02-18T19:41:59 |
add functionality for Status or Off
a69733d to
8ee5d85
Compare
Member
|
What was the difference between anti-collision and white navigation? 👀 There was some dead code added back and some duplication of color handling. Docs are not corrected yet. @Claudio-Chies could you double-check this still does what you intended? |
Comment on lines
+67
to
+74
| 0: Status | ||
| 1: White Navigation | ||
| 2: Red Navigation | ||
| 3: Green Navigation | ||
| 4: Status / White Navigation | ||
| 5: Status / Red Navigation | ||
| 6: Status / Green Navigation | ||
| 7: Status / Off |
Contributor
There was a problem hiding this comment.
- What are the different navigation types? I.e. does white navigation mean anything vs red navigation? Is this standard aircraft terminology?
- What does anti-collision mean - is it just a warning that something is in anti collision mode?
- For 4-7 does this mean "nromally in colour navigation but perhaps display a status warning under some conditions? What status are possible.
It seems to me that we need a Led status harware section under https://docs.px4.io/main/en/hardware/drone_parts explaining all this, linking to UAVCAN, listing models that have been tested.
Member
There was a problem hiding this comment.
@hamishwillee Thanks for the feedback!
What are the different navigation types?
- Good point, it's meant for "navigation lights" that are either white red or green in color. But "Navigation" is confusing here I agree. Let's just specify the color and write navigation light in the description. ⚙️
anti-collision mean
- I removed it, was doing the exact same thing as the white LED, need to update docs.
Background: There is a UAVCAN LED ID for "anti-collision lights" but with UAVCAN: Configurable LED Light Control with Flexible Addressing #26253 you can set any ID you want including that one and we don't need to carry any of this spcifically. I think the users per light ID are really sparse.
For 4-7
- Let me try to make a table that we can then put in docs:
On or off is determined byUAVCAN_LGT_MODE(default when armed = on). And then it follows the table:
UAVCAN_LGT_FNx |
Off | On |
|---|---|---|
| 0 | Off | Status |
| 1 | Off | White |
| 2 | Off | Red |
| 3 | Off | Green |
| 4 | Status | White |
| 5 | Status | Red |
| 6 | Status | Green |
| 7 | Status | Off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the functionality of #26253
Adds option for colored navigation lights, and also hybrid setup where depending on
UAVCAN_LGT_MODEthe behaviour of the RGB leds change from Status lights to navigation lights.