Vertiq Parameter Setting Reliability Update#26521
Open
vertiq-jack wants to merge 1 commit intoPX4:mainfrom
Open
Vertiq Parameter Setting Reliability Update#26521vertiq-jack wants to merge 1 commit intoPX4:mainfrom
vertiq-jack wants to merge 1 commit intoPX4:mainfrom
Conversation
…uration. update Vertiq submodule pointer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level
The purpose of this pull request is to update how we handle parameters for Vertiq IO by improving the backend for faster and more reliable parameter configuration. An associated update to the PX4 fork of our C++ API is found here: PX4/iq-module-communication-cpp#2.
What we’ve added and fixed
The update to our C++ API allows for dynamic updates of a client’s Object ID (i.e. the module ID it talks to). The PX4 update in this PR leverages the Update Entry IDs function to reduce the use of dynamic memory allocation used for parameter setting across multiple module IDs. Additionally, we also now listen to uORB parameter update subscription every 10ms instead of every 1s.
Test flight: https://drive.google.com/file/d/1OWzT5aesN0QkGH6YAnTuH67t5gRZ92wj/view?usp=sharing
Flight logs:
https://drive.google.com/file/d/1Jv6bvp2qu0CcQvh7oeIevGOxnYT0fdNY/view?usp=sharing