Open
Conversation
hamishwillee
commented
Feb 19, 2026
Comment on lines
+3
to
+5
| # This message provides a representation of a manual control input, such as an RC controller or MAVLink controller (Joystick). | ||
| # It also defines the manual_control_setpoint topic, which represents the selected input. | ||
| # The message includes fields for the roll, pitch, yaw, throttle and flaps, along with auxiliary channels and button states. |
Contributor
Author
There was a problem hiding this comment.
Is this accurate and sufficient? Essentially we want to define the uses, publishers and consumers.
As stated I think this represents each of the inputs, and also it represent a selected input. However it might be a synthesized input. Can you confirm?
Contributor
There was a problem hiding this comment.
What do you mean by synthesized? Since input can be coming from Mavlink MANUAL_CONTROL messages you have no idea how that was produced. Usually joystick, but could be generated by anything.
hamishwillee
commented
Feb 19, 2026
hamishwillee
commented
Feb 19, 2026
hamishwillee
commented
Feb 19, 2026
Comment on lines
25
to
26
| # on a common RC mode 1/2/3/4 remote/joystick the stick deflection: -1 is down/left, 1 is up/right | ||
| # Note: QGC sends throttle/z in range [0,1000] - [0,1]. The MAVLink input conversion [0,1] to [-1,1] is at the moment kept backwards compatible. |
Contributor
Author
There was a problem hiding this comment.
This wouldn't be rendered. Can this move up into the long description?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates ManualControlSetpoint topic to the current docs standard. I did some creative writing. Needs review. See comments inline.