Open
Conversation
lynxplay
requested changes
Jan 15, 2026
| * Event when an Entity starts touching water or not. This includes even small amounts of flowing water. | ||
| */ | ||
| @NullMarked | ||
| public class EntityTouchWaterEvent extends EntityEvent{ |
Contributor
There was a problem hiding this comment.
Naming feels very confusing.
EntityTouchWaterEvent for when an entity doesn't touch water feels kinda rough.
Formatting also also off here, missing space after EntityEvent.
What prevents us from just having two events for this?
github-project-automation
bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this is a particularly niche event, the logic was already all there in the source.
Use case for us is status effects when touching (corrupted) water and applying damage, etc.