Reduce SizedQueue to a regular Queue in monitoring radios #3936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Oof; I should start following through on some of the along-the-way details I run across. I had done exactly this PR's work locally for tangential reasons, but didn't get back to verify that it was a valid change for beyond just my laptop.
Thanks for this and the related verification research.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The radios do not make use of the .qsize() functionality of queues, and so th (broken, see #3856) platform-specific sized queue functionality is not necessary.
This is part of a series of PRs to remove that platform-specific functionality entirely - see PR #3932.
Changed Behaviour
This code is part of broken behaviour on Macs. The behaviour will be slightly better but still broken after this PR on that platform.
Otherwise, the queue should not behave any differently.
Type of change