Refactor foreach loops to use explicit .Where() filtering in ScriptGenerator#1899
Merged
danielmarbach merged 2 commits intoscript-builder-loadingfrom Jan 12, 2026
Merged
Conversation
Co-authored-by: danielmarbach <174258+danielmarbach@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix unhandled exception for missing assembly in SqlPersistenceTask
Refactor foreach loops to use explicit .Where() filtering in ScriptGenerator
Jan 12, 2026
danielmarbach
approved these changes
Jan 12, 2026
Contributor
|
Given that we already use Linq in this class I think that is fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review feedback identified three foreach loops in
ScriptGenerator.csthat implicitly filtered their target sequences using nestedifstatements. This PR refactors them to use explicit.Where()clauses.Changes
.Where()filtering:Before/After
The refactoring makes filtering intent explicit while preserving identical behavior and lazy evaluation semantics.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.