Skip to content

Refactor foreach loops to use explicit .Where() filtering in ScriptGenerator #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielmarbach merged 2 commits into from
Jan 12, 2026
Merged

Refactor foreach loops to use explicit .Where() filtering in ScriptGenerator #1899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08c36ab
Initial plan
Copilot Jan 12, 2026
6790d46
Refactor foreach loops to use explicit .Where() filtering
Copilot Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions src/ScriptBuilder/ScriptGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,33 +158,24 @@ void Promote(string replicationPath)
static IEnumerable<string> CollectAssemblyFiles(string assemblyFolderPath, IReadOnlyList<string>? referencePaths)
{
var seen = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
foreach (var file in Directory.GetFiles(RuntimeEnvironment.GetRuntimeDirectory(), "*.dll"))
foreach (var file in Directory.GetFiles(RuntimeEnvironment.GetRuntimeDirectory(), "*.dll").Where(f => seen.Add(Path.GetFileName(f))))
{
if (seen.Add(Path.GetFileName(file)))
{
yield return file;
}
yield return file;
}

foreach (var file in Directory.EnumerateFiles(assemblyFolderPath, "*.dll", SearchOption.AllDirectories))
foreach (var file in Directory.EnumerateFiles(assemblyFolderPath, "*.dll", SearchOption.AllDirectories).Where(f => seen.Add(Path.GetFileName(f))))
{
if (seen.Add(Path.GetFileName(file)))
{
yield return file;
}
yield return file;
}

if (referencePaths is null)
{
yield break;
}

foreach (var referencePath in referencePaths)
foreach (var referencePath in referencePaths.Where(rp => File.Exists(rp) && seen.Add(Path.GetFileName(rp))))
{
if (File.Exists(referencePath) && seen.Add(Path.GetFileName(referencePath)))
{
yield return referencePath;
}
yield return referencePath;
}
}
}