Skip to content

Fix race condition in RepeatedFailuresOverTimeCircuitBreaker#1557

Merged
WilliamBZA merged 6 commits intorelease-7.0from
cherry-pick-1372-to-7.0
Jun 18, 2025
Merged

Fix race condition in RepeatedFailuresOverTimeCircuitBreaker#1557
WilliamBZA merged 6 commits intorelease-7.0from
cherry-pick-1372-to-7.0

Conversation

@WilliamBZA
Copy link
Member

@WilliamBZA WilliamBZA commented Jun 11, 2025

@afprtclr afprtclr requested review from afprtclr and hsvotwa June 11, 2025 11:48
@afprtclr
Copy link

@WilliamBZA CI for linux didn't run. You need to update to ubuntu-latest.

@WilliamBZA
Copy link
Member Author

The linux build won't work for V7 as this still has support for .NET Framework. See previous V7 release builds: https://github.com/Particular/NServiceBus.SqlServer/actions/runs/15504979270/job/43658586230.

I think we're safe to proceed without the Linux build here.

@WilliamBZA WilliamBZA force-pushed the cherry-pick-1372-to-7.0 branch from 91b0b1f to d437e40 Compare June 12, 2025 10:23
@afprtclr
Copy link

The linux build won't work for V7 as this still has support for .NET Framework. See previous V7 release builds: https://github.com/Particular/NServiceBus.SqlServer/actions/runs/15504979270/job/43658586230.

I think we're safe to proceed without the Linux build here.

I had to fix this for Service Control last month, so I'll stick to my guns.

However, you definitely need to fix this

or the pipeline will not execute and you won't be able to release.

@WilliamBZA WilliamBZA force-pushed the cherry-pick-1372-to-7.0 branch from ce33b54 to 4ea663b Compare June 12, 2025 17:06
Copy link

@afprtclr afprtclr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update ubuntu in the release pipeline as well:

@WilliamBZA WilliamBZA added this to the 7.0.11 milestone Jun 18, 2025
@WilliamBZA WilliamBZA added the Bug label Jun 18, 2025
@WilliamBZA WilliamBZA requested a review from afprtclr June 18, 2025 10:26
@WilliamBZA WilliamBZA merged commit c842599 into release-7.0 Jun 18, 2025
4 checks passed
@WilliamBZA WilliamBZA deleted the cherry-pick-1372-to-7.0 branch June 18, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants