Handle null InstallerSettings in installers #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you explain the scenario that would ever cause the |
Contributor
Author
|
hi @bording, thank you for your comment. If you use more than one form of transport within the same library, one of them will be optional. When Mongo is set as optional, we pass empty settings, which leads to the error |
bording
changed the title
bording
approved these changes
Sep 30, 2025
Member
|
@hasancanguler Thanks for the contribution. I've made a few changes and merged the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no settings are found for the installer, the Get method fails. To fix this issue, it has been replaced with GetOrDefault, and a null check has been added