Skip to content

Handle null InstallerSettings in installers #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bording merged 3 commits into from
Sep 30, 2025
Merged

Handle null InstallerSettings in installers #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
852257e
Replace settings.Get
hasancanguler Sep 25, 2025
76352f0
Use pattern matching for null check
bording Sep 30, 2025
9e3bafc
Apply change to other installers
bording Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/NServiceBus.Storage.MongoDB/Outbox/OutboxInstaller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ sealed class OutboxInstaller(IReadOnlySettings settings, IServiceProvider servic
{
public async Task Install(string identity, CancellationToken cancellationToken = default)
{
var installerSettings = settings.Get<InstallerSettings>();
if (installerSettings.Disabled || installerSettings.OutboxDisabled || !settings.IsFeatureActive(typeof(OutboxStorage)))
var installerSettings = settings.GetOrDefault<InstallerSettings>();

if (installerSettings is null || installerSettings.Disabled || installerSettings.OutboxDisabled || !settings.IsFeatureActive(typeof(OutboxStorage)))
{
return;
}
Expand Down
5 changes: 3 additions & 2 deletions src/NServiceBus.Storage.MongoDB/Sagas/SagaInstaller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,9 @@ sealed class SagaInstaller(IReadOnlySettings settings, IServiceProvider serviceP
{
public async Task Install(string identity, CancellationToken cancellationToken = default)
{
var installerSettings = settings.Get<InstallerSettings>();
if (installerSettings.Disabled || !settings.IsFeatureActive(typeof(SagaStorage)))
var installerSettings = settings.GetOrDefault<InstallerSettings>();

if (installerSettings is null || installerSettings.Disabled || !settings.IsFeatureActive(typeof(SagaStorage)))
{
return;
}
Expand Down
5 changes: 3 additions & 2 deletions src/NServiceBus.Storage.MongoDB/Subscriptions/SubscriptionInstaller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ sealed class SubscriptionInstaller(IReadOnlySettings settings, IServiceProvider
{
public async Task Install(string identity, CancellationToken cancellationToken = default)
{
var installerSettings = settings.Get<InstallerSettings>();
if (installerSettings.Disabled || !settings.IsFeatureActive(typeof(SubscriptionStorage)))
var installerSettings = settings.GetOrDefault<InstallerSettings>();

if (installerSettings is null || installerSettings.Disabled || !settings.IsFeatureActive(typeof(SubscriptionStorage)))
{
return;
}
Expand Down