Fixes double retry when using edit and retry #2425
Conversation
There was a problem hiding this comment.
This is just a clean-up.
We used to have two edit and retry dialogs, but in reality only EditRetryDialog2.vue was being used, so all i have done is to rename EditRetryDialog2.vue -> EditRetryDialog.vue.
The reason we had 2 dialogs was when we had a feature flag, and we forogt to do this clean-up as part of removing the feature flag.
| isConfirmDialogVisible.value = false; | ||
| const message = `Retrying the edited message ${state.value.data.id} ...`; | ||
| await showToastAfterOperation(store.retryMessage, TYPE.INFO, "Info", message); |
There was a problem hiding this comment.
This is the actual fix, we no longer call store.retryMessage from here given that is already called in the dialog itself.
|
@johnsimons I have verified that the specific issue that was reported is not longer happening on this branch. |
johnsimons
force-pushed
the
john/retry-fix
branch
from
56be332 to
ca75e81
Compare
|
@jpalac I rolled back those cleanups |
Fixes #2424