Skip to content

Fixes double retry when using edit and retry #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Fixes double retry when using edit and retry #2425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Frontend/src/components/messages2/EditAndRetryButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script setup lang="ts">
import { useMessageStore } from "@/stores/MessageStore";
import { computed, ref } from "vue";
import { showToastAfterOperation } from "@/composables/toast";
import { useShowToast } from "@/composables/toast";
import { TYPE } from "vue-toastification";
import EditRetryDialog2 from "@/components/failedmessages/EditRetryDialog2.vue";
import { MessageStatus } from "@/resources/Message";
Expand All @@ -19,8 +19,7 @@ const handleConfirm = async () => {
isConfirmDialogVisible.value = false;

const message = `Retrying the edited message ${state.value.data.id} ...`;
await showToastAfterOperation(store.retryMessage, TYPE.INFO, "Info", message);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual fix, we no longer call store.retryMessage from here given that is already called in the dialog itself.


useShowToast(TYPE.INFO, "Info", message);
await store.pollForNextUpdate(FailedMessageStatus.Resolved);
};

Expand Down