This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Fix Ctrl + Z & Ctrl + Y not saving the allocated attribute stats #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Jan 18, 2025
LocalIdentity
merged commit 286d361
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
LocalIdentity
changed the title
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302
Description of the problem being solved:
The createUndoState for Spec wasn't copying the hashOverrides correctly, so if you control-z after decallocated any attribute node, it reallocates as an empty Attribute and not whichever was set before.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: