Fix crash when sorting some gems by Full DPS #9143
Open
+73
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we were checking to see if a gem could be affected by a possible support gem we were not considering if the gem had a additional granted effect which was the supporting part of the gem Instead of using the granted effect of the support, we were using the granted effect of the gem which caused a bunch of issues for the code that only expects to deal with supports Also applied this logic to cross linked supports too as I noticed it had a similar issue Also made cross link supports skip it's own socketgroup as it's trying to look for other socketgroups that can support it e.g. Ngamahu's Flame was checking it's own Molten Burst gem group which couldn't possible have supports
Supports granted by many items do not have any gemData as they are just a grantedEffect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were checking to see if a gem could be affected by a possible support gem we were not considering if the gem had a additional granted effect which was the supporting part of the gem
Instead of using the granted effect of the support, we were using the granted effect of the gem which caused a bunch of issues for the code that only expects to deal with supports
Also applied this logic to cross linked supports too as I noticed it had a similar issue
Also made cross link supports skip it's own socketgroup as it's trying to look for other socketgroups that can support it
e.g. Ngamahu's Flame was checking it's own Molten Burst gem group which couldn't possible have supports
Fixes #9137