Skip to content

Fix Heraldry not granting Exposure to enemies #9179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
+50 −6
Open

Fix Heraldry not granting Exposure to enemies #9179

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4bb078
Fix Heraldry not granting Exposure to enemies
Nov 5, 2025
c6d4c4f
Test for bug
Nov 5, 2025
0bcb9a2
Fix test
Nov 5, 2025
0461407
Enemy curse effect test
Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/Modules/CalcPerform.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,10 +565,19 @@ local function determineCursePriority(curseName, activeSkill)
return basePriority + socketPriority + slotPriority + sourcePriority
end

local function applyEnemyModifiers(actor)
-- Process enemy modifiers
local function applyEnemyModifiers(actor, clearCache)
if clearCache or not actor.appliedEnemyModifiers then
actor.appliedEnemyModifiers = { }
end
local cache = actor.appliedEnemyModifiers
local enemyDB = actor.enemy.modDB
for _, value in ipairs(actor.modDB:Tabulate(nil, nil, "EnemyModifier")) do
actor.enemy.modDB:AddMod(modLib.setSource(value.value.mod, value.value.mod.source or value.mod.source))
local mod = value.value and value.value.mod
if mod and not cache[mod] then
local source = mod.source or value.mod.source
enemyDB:AddMod(modLib.setSource(mod, source))
cache[mod] = true
end
end
end

Expand All @@ -579,6 +588,9 @@ local function doActorMisc(env, actor)
local output = actor.output
local condList = modDB.conditions

-- Process enemy modifiers
applyEnemyModifiers(actor)

-- Add misc buffs/debuffs
if env.mode_combat then
if env.player.mainSkill.baseSkillModList:Flag(nil, "Cruelty") then
Expand Down Expand Up @@ -1170,11 +1182,11 @@ function calcs.perform(env, skipEHP)
output.WarcryPower = modDB:Override(nil, "WarcryPower") or modDB:Sum("BASE", nil, "WarcryPower") or 0
modDB.multipliers["WarcryPower"] = output.WarcryPower

applyEnemyModifiers(env.player)
applyEnemyModifiers(env.player, true)
if env.minion then
applyEnemyModifiers(env.minion)
applyEnemyModifiers(env.minion, true)
end
applyEnemyModifiers(env.enemy)
applyEnemyModifiers(env.enemy, true)

for _, activeSkill in ipairs(env.player.activeSkillList) do
if activeSkill.skillTypes[SkillType.Brand] then
Expand Down