Merged
Conversation
Contributor
CannonLock
commented
Feb 5, 2025
CannonLock
commented
- Add Origin metric page to the director
- Add click through interactions on data points to allow investigation to outlier servers
CannonLock
force-pushed
the
origins-on-director
branch
from
36e8158 to
cea97a7
Compare
Contributor
Author
Screen.Recording.2025-02-05.at.2.08.43.PM.mov |
CannonLock
force-pushed
the
origins-on-director
branch
from
cea97a7 to
ecaead6
Compare
Contributor
|
To ensure the failed tests are not due to outdated code, could you rebase this PR against the latest main when you have a moment? |
Contributor
Author
|
@h2zh I had the same thought and rebased this onto a version from 2 days ago. Not sure what is going on with the tests. |
Contributor
Author
|
@h2zh Looks like there are issues with the website build I will address, my bad |
Contributor
Author
|
Accidentally closed with comment |
- Add Origin metric page to the director - Add click through interactions on data points to allow investigation to outlier servers
…erverType specific views
- Add the version to the card title - Add a button to go to the servers metrics
CannonLock
force-pushed
the
origins-on-director
branch
from
ecaead6 to
88bc244
Compare
- Fix the headers to they are sticky on the tables - Add the by project metrics table - Add boxplots for the transfer bytes and operations to see top caches
CannonLock
force-pushed
the
origins-on-director
branch
from
c317fc1 to
39615a5
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces pages for displaying origin metrics and implements click-through interactions for investigating outlier servers in both the director and cache views. Key changes include:
- Addition of the OriginMetricPage and CacheMetricPage components for metrics display.
- Updates to various graph and table components to support clickable links and improved UI styling.
- Removal of legacy components (e.g., ServerTable and DataTable) and consolidation of metric display logic.
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| web_ui/frontend/components/graphs/OriginMetricPage.tsx | New component for displaying origin metrics with several metric graphs and tables. |
| web_ui/frontend/components/graphs/GraphContext.tsx | Updated URL parameter handling in state updates. |
| web_ui/frontend/components/graphs/CacheMetricPage.tsx | New component for cache metrics (with similar structure to OriginMetricPage). |
| web_ui/frontend/components/StyledHeadTableCell.tsx | Added styled table header cell for consistent UI. |
| web_ui/frontend/components/ServerTable.tsx | Removed legacy server table component. |
| web_ui/frontend/app/origin/metrics/page.tsx | Updated app routing to use the new OriginMetricPage. |
| web_ui/frontend/app/director/metrics/page.tsx | Enhanced director metrics page with additional metrics and a project table. |
| web_ui/frontend/app/director/metrics/origin/page.tsx | Added a dedicated origin metrics page for the director view. |
| web_ui/frontend/app/director/metrics/components/TransferBarGraph.tsx | Adjusted SWR key and added a console log for debugging purposes. |
| web_ui/frontend/app/director/metrics/components/StorageTable.tsx | Updated table component to include navigation links and styled header cells. |
| web_ui/frontend/app/director/metrics/components/MetricBoxPlot.tsx | Enhanced click interactions with router integration and server type lookup. |
| web_ui/frontend/app/cache/metrics/page.tsx | Modified cache metrics page routing (note: incorrect import detected). |
| web_ui/frontend/app/director/components/DirectorCard.tsx | Updated card component to display version details and provide admin links. |
Comments suppressed due to low confidence (2)
web_ui/frontend/components/graphs/OriginMetricPage.tsx:139
- The title for the BigBytesMetric with type 'readv' is missing a closing backtick, which could lead to rendering issues.
title={'Bytes `readv}
web_ui/frontend/components/graphs/CacheMetricPage.tsx:139
- The title for the BigBytesMetric with type 'readv' is missing a closing backtick; please correct it to ensure proper display.
title={'Bytes `readv}
web_ui/frontend/app/director/metrics/components/TransferBarGraph.tsx
Outdated
Show resolved
Hide resolved
web_ui/frontend/app/director/metrics/components/MetricBoxPlot.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
h2zh
requested changes
Apr 2, 2025
Contributor
h2zh
left a comment
h2zh
left a comment
There was a problem hiding this comment.
This review's emphasis is on the Prometheus. I also skim through the code changes in /app, while the live webpage interactive test is impossible in dev environment for this feature.
- Make buildMetric louder when issues arise - Optimize buildMetric to leave out cruft when building empty arg string - Delete unused components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.