Fix weird consts issue in from_plxpr
#2128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Oct 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2128 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 91 91
Lines 10609 10610 +1
Branches 999 999
=======================================
+ Hits 10333 10334 +1
Misses 218 218
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paul0403
added a commit
that referenced
this pull request
Oct 20, 2025
paul0403
added a commit
that referenced
this pull request
Oct 20, 2025
**Context:** Recently plxpr pipeline's control flow handling of `consts` for subscope body jaxprs were updated, but one place was missed in the update. #2128 **Description of the Change:** `handle_for_loop` correctly uses length of `new_consts`. **Benefits:** Things are correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When updating tests for #2078 , I was getting weird failures on this test:
catalyst/frontend/test/pytest/test_gradient.py
Line 757 in 5eec7c7
Basically what was happening was that the conversion of the target jaxpr was reordering the consts. So we need to use the consts for the new jaxpr, not the input jaxpr.
Description of the Change:
In all relevant translation steps, we pull the consts from the new jaxpr, not the original inputs.
Benefits:
Get correct results without errors.
Possible Drawbacks:
I didn't test all the other control flow primitives that might have the same issue, because I don't know how to trigger this is other cases.
Related GitHub Issues:
[sc-101609]