Skip to content

Conversation

@trwyant
Copy link
Contributor

@trwyant trwyant commented Sep 19, 2025

The description for diagnostic Possible attempt escape whitespace in qw() list mis-states the actual number of elements produced by the example (the first commit) and contains a minor grammar error (the second commit). This pull request corrects both issues.


  • This set of changes does not require a perldelta entry.

@jkeenan
Copy link
Contributor

jkeenan commented Sep 20, 2025

These changes are so small that we can reasonably squash them into one.

@khwilliamson
Copy link
Contributor

It would be fine to squash them; or fine to leave them as-is. @trwyant what do you want?

@trwyant
Copy link
Contributor Author

trwyant commented Sep 24, 2025

Makes no difference to me. It's two commits because I already pushed before I recognized and decided to fix the grammar error. If squish, do you do it or do I?

PS sorry for the delay in response. It's been busy.

@khwilliamson
Copy link
Contributor

If you feel like squashing do so; otherwise let us know.

@trwyant
Copy link
Contributor Author

trwyant commented Sep 27, 2025

I'm certainly willing, but this is new ground for me, and I would appreciate a co-pilot, or at least a bit of hand-holding. As I understand it, what's wanted is something like

$ git fetch upstream      # Fetch from Perl/perl5
$ git checkout trw_perldiag_qw_escape_whitespace
$ git rebase -i upstream/master
# ... Choose squash for all of your commits, except the first one.
# ... Edit the commit message to make sense, and describe all your changes.
$ git push origin trw_perldiag_qw_escape_whitespace -f

Cribbed from Steve Klabnik's 12-year-old post, but seems consistent whith what I get rummaging through Stack Overflow.

@trwyant trwyant force-pushed the trw_perldiag_qw_escape_whitespace branch from 6ad89fb to 8ec6f2a Compare September 28, 2025 18:51
@trwyant
Copy link
Contributor Author

trwyant commented Sep 28, 2025

It's squashed, for better or worse. Sorry for the hand-holding request, but changing pushed history gives me the willies. Thanks for the help.

@khwilliamson khwilliamson merged commit 42a09c0 into Perl:blead Sep 28, 2025
2 checks passed
@khwilliamson
Copy link
Contributor

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants