Modernize attributes.pm to v5.40
#23769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonerd
force-pushed
the
modernize-attributes.pm
branch
from
e55597e to
713a9fb
Compare
JRaspass
suggested changes
Sep 26, 2025
ext/attributes/attributes.pm
Outdated
| my $svref = shift; | ||
| my $svtype = uc reftype($svref); | ||
| my $stash = _guess_stash($svref); | ||
| $stash = caller unless defined $stash; |
Contributor
There was a problem hiding this comment.
We could use // here:
my $stash = _guess_stash($svref) // caller;
Contributor
There was a problem hiding this comment.
No need for 1; at the end of the file.
JRaspass
reviewed
Sep 27, 2025
| %EXPORT_TAGS = (ALL => [@EXPORT, @EXPORT_OK]); | ||
|
|
||
| use strict; | ||
| our @EXPORT_OK = qw(get reftype); |
Contributor
There was a problem hiding this comment.
I wonder if we could just do *reftype = \&builtin::reftype in this file and drop the reftype func from attributes.xs?
Contributor
Author
There was a problem hiding this comment.
Yes, that would be reasonable too. Annoyingly, we need to keep the symbol present, in case some code out there somewhere actually calls attributes::reftype() - i.e. we can't simply use a lexical import here.
* Reset `@warnings` array between tests so failures in one block don't leak into all the later ones * Print the next warning using `diag` if we fail because it isn't empty
…tes.xs Previously the XS code always checked its immediate caller for warnings. This was fine when core perl invokes it directly in a `:prototype` warning, but was checking the wrong layer when invoked indirectly via `attributes::import`. In that case, it meant that it was sensitive to, and printed warnings as it coming from attributes.pm itself, rather than the intended caller; i.e. the location of the `use attributes ...` statement. This is fixed by using `caller_cx()` to walk up the caller stack looking for a call frame not from the `attributes` package.
leonerd
force-pushed
the
modernize-attributes.pm
branch
from
713a9fb to
004837f
Compare
* use v5.40 * `our` on package globals * Signatures on subs * Lexical subs when not required to be visible * `module_true` means no need for ending `1;` * Use `//` operator * Remove `reftype` from attributes.xs and use builtin::reftype instead
leonerd
force-pushed
the
modernize-attributes.pm
branch
from
004837f to
dd15d23
Compare
Contributor
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ouron package globalsThis first required a bugfix in attributes.xs, whose details are outlined in its own commit.