chore(deps-dev): bump eslint from 8.56.0 to 9.26.0 in /frontend/packages/sdk #1646
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 8.56.0 to 9.26.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/v9.26.0/CHANGELOG.md) - [Commits](eslint/eslint@v8.56.0...v9.26.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 9.26.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| @@ -86,7 +86,7 @@ | |||
| "@vitest/ui": "^0.34.4", | |||
There was a problem hiding this comment.
Bug: ESLint plugins like @typescript-eslint/eslint-plugin and eslint-plugin-import are not updated to versions compatible with the ESLint 9 upgrade, which will cause linting scripts to fail.
Severity: CRITICAL
Suggested Fix
Update the versions of @typescript-eslint/eslint-plugin, @typescript-eslint/parser, and eslint-plugin-import in package.json to versions that are compatible with ESLint 9. For example, @typescript-eslint packages should be updated to v8.x or later.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: frontend/packages/sdk/package.json#L86
Potential issue: The `package.json` file updates ESLint to version 9, but several ESLint
plugins, including `@typescript-eslint/eslint-plugin`, `@typescript-eslint/parser`, and
`eslint-plugin-import`, were not updated to compatible versions. The currently specified
versions (`^6.6.0` for typescript-eslint plugins and `^2.28.1` for the import plugin)
have peer dependency constraints that do not support ESLint 9. This incompatibility will
cause the `yarn eslint` and `yarn eslint:ci` scripts to fail at runtime when ESLint
attempts to load these unsupported plugins, breaking the linting process for both local
development and CI pipelines.
Did we get this right? 👍 / 👎 to inform future reviews.
| "eslint": "^9.26.0", | ||
| "eslint-config-prettier": "^9.0.0", |
There was a problem hiding this comment.
Bug: The eslint scripts use the --no-eslintrc flag, which was removed in ESLint 9. This will cause the linting commands to fail.
Severity: CRITICAL
Suggested Fix
In the eslint and eslint:ci scripts within package.json, replace the deprecated --no-eslintrc flag with its replacement, --no-config-lookup, to ensure compatibility with ESLint 9.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: frontend/packages/sdk/package.json#L89-L90
Potential issue: The `eslint` and `eslint:ci` npm scripts in `package.json` use the
`--no-eslintrc` command-line flag. This flag was removed in ESLint v9.0.0, which this
pull request upgrades to. When these scripts are executed, ESLint will receive an
unrecognized CLI argument and exit with an error. This will cause all linting tasks to
fail, breaking a critical part of the development and CI workflow.
Did we get this right? 👍 / 👎 to inform future reviews.
Bumps eslint from 8.56.0 to 9.26.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
8bbabc49.26.016f5ff7Build: changelog update for 9.26.05b247c8chore: upgrade to@eslint/js@9.26.0(#19681)d6fa4acchore: package.json update for@eslint/jsreleasee9754e7feat: add reportGlobalThis to no-shadow-restricted-names (#19670)0fa2b7afeat: add suggestions foreqeqeqrule (#19640)dd98d63docs: Update README96e84defix: check cache file existence before deletion (#19648)c25e858docs: Update README0958690chore: disambiguate internal typesLanguageOptionsandRule(#19669)Maintainer changes
This version was pushed to npm by eslintbot, a new releaser for eslint since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.