Skip to content

chore(deps-dev): bump eslint from 8.56.0 to 9.26.0 in /frontend/packages/sdk #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps-dev): bump eslint from 8.56.0 to 9.26.0 in /frontend/packages/sdk #1646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/packages/sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"@vitest/ui": "^0.34.4",
Copy link

@sentry sentry bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: ESLint plugins like @typescript-eslint/eslint-plugin and eslint-plugin-import are not updated to versions compatible with the ESLint 9 upgrade, which will cause linting scripts to fail.
Severity: CRITICAL

Suggested Fix

Update the versions of @typescript-eslint/eslint-plugin, @typescript-eslint/parser, and eslint-plugin-import in package.json to versions that are compatible with ESLint 9. For example, @typescript-eslint packages should be updated to v8.x or later.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: frontend/packages/sdk/package.json#L86

Potential issue: The `package.json` file updates ESLint to version 9, but several ESLint
plugins, including `@typescript-eslint/eslint-plugin`, `@typescript-eslint/parser`, and
`eslint-plugin-import`, were not updated to compatible versions. The currently specified
versions (`^6.6.0` for typescript-eslint plugins and `^2.28.1` for the import plugin)
have peer dependency constraints that do not support ESLint 9. This incompatibility will
cause the `yarn eslint` and `yarn eslint:ci` scripts to fail at runtime when ESLint
attempts to load these unsupported plugins, breaking the linting process for both local
development and CI pipelines.

Did we get this right? 👍 / 👎 to inform future reviews.

"concurrently": "^8.2.1",
"esbuild": "^0.18.11",
"eslint": "^8.48.0",
"eslint": "^9.26.0",
"eslint-config-prettier": "^9.0.0",
Comment on lines +89 to 90
Copy link

@sentry sentry bot Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The eslint scripts use the --no-eslintrc flag, which was removed in ESLint 9. This will cause the linting commands to fail.
Severity: CRITICAL

Suggested Fix

In the eslint and eslint:ci scripts within package.json, replace the deprecated --no-eslintrc flag with its replacement, --no-config-lookup, to ensure compatibility with ESLint 9.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: frontend/packages/sdk/package.json#L89-L90

Potential issue: The `eslint` and `eslint:ci` npm scripts in `package.json` use the
`--no-eslintrc` command-line flag. This flag was removed in ESLint v9.0.0, which this
pull request upgrades to. When these scripts are executed, ESLint will receive an
unrecognized CLI argument and exit with an error. This will cause all linting tasks to
fail, breaking a critical part of the development and CI workflow.

Did we get this right? 👍 / 👎 to inform future reviews.

"eslint-import-resolver-alias": "^1.1.2",
"eslint-plugin-import": "^2.28.1",
Expand Down
Loading
Loading