Skip to content

Conversation

@chaserli
Copy link
Contributor

@chaserli chaserli commented Feb 26, 2025

Fix incompatiblity with CnCNet/yrpp-spawner#27

@chaserli chaserli added the Minor Minor feature and/or fix, not a lot of changes or they are not significant label Feb 26, 2025
@Starkku
Copy link
Contributor

Starkku commented Feb 26, 2025

Any chance of sharing with the class what's up here instead of being cryptic as always for no good reason?

@github-actions
Copy link

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@chaserli
Copy link
Contributor Author

Any chance of sharing with the class what's up here instead of being cryptic as always for no good reason?

No clue so far. I got crash at the debut of S24 when the SC base was revealed. This just fixed that.
Perhaps @shmocz @Belonit know.
19.0 is in rdata and you should've altered its memory protection attributes in the first place.

@Belonit
Copy link
Member

Belonit commented Feb 26, 2025

Any chance of sharing with the class what's up here instead of being cryptic as always for no good reason?

No clue so far. I got crash at the debut of S24 when the SC base was revealed. This just fixed that. Perhaps @shmocz @Belonit know. 19.0 is in rdata and you should've altered its memory protection attributes in the first place.

I also have no idea what we are talking about

@Metadorius
Copy link
Member

Metadorius commented Feb 26, 2025

19.0 is in rdata

I don't know what you are referring to

@chaserli
Copy link
Contributor Author

19.0 is in rdata

I don't know what you are referring to

0x7F5B20 (19.0) is in rdata. Previously it was being modified constantly without being patched constantly.

@chaserli chaserli changed the title Fix incompatiblity with https://github.com/CnCNet/yrpp-spawner/pull/27 Fix incorrect implementation of tunnel loco speed Feb 26, 2025
@Belonit
Copy link
Member

Belonit commented Feb 28, 2025

We are talking about TunnellocomotionClass::TunnelmovementSpeed (0x7F5B20)

@TaranDahl TaranDahl added ❓Phobos bug Something isn't working properly ⚙️T1 T1 maintainer review is sufficient labels Mar 1, 2025
@ZivDero ZivDero merged commit 5ab7800 into Phobos-developers:develop Mar 7, 2025
18 checks passed
ZivDero added a commit that referenced this pull request Mar 7, 2025
ZivDero added a commit that referenced this pull request Mar 7, 2025
Coronia pushed a commit that referenced this pull request Mar 8, 2025
Metadorius pushed a commit to Metadorius/Phobos that referenced this pull request Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Minor feature and/or fix, not a lot of changes or they are not significant ❓Phobos bug Something isn't working properly ⚙️T1 T1 maintainer review is sufficient

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants