Skip to content

Enable PWM for illumination LEDs on LL2+ and LL3#124

Merged
mcm001 merged 3 commits intoPhotonVision:mainfrom
thatcomputerguy0101:limelight-pwm
Feb 2, 2026
Merged

Enable PWM for illumination LEDs on LL2+ and LL3#124
mcm001 merged 3 commits intoPhotonVision:mainfrom
thatcomputerguy0101:limelight-pwm

Conversation

@thatcomputerguy0101
Copy link
Contributor

@thatcomputerguy0101 thatcomputerguy0101 commented Jan 28, 2026

This enables PWM on pins 13 and 18 to control the built-in dimmable illumination LEDs on Limelight 2+ and 3. The symlink at /boot/config.txt exists since that is the only path diozero checks for pwm configuration right now, and should be removed once diozero is updated to check /boot/firmware/config.txt or another source of PWM information (diozero#230).

Both LL2+ and LL3 have non-flickery LED dimming with these changes.

Needed to fix flickering LEDs in photonvision#2335.

@thatcomputerguy0101
Copy link
Contributor Author

Deploying this image on a LL2+ fixed the flickery LED issues of photonvision#2235

@thatcomputerguy0101
Copy link
Contributor Author

I might be able to test a LL3 tomorrow.

@thatcomputerguy0101 thatcomputerguy0101 marked this pull request as ready for review January 29, 2026 19:04
@thatcomputerguy0101
Copy link
Contributor Author

LL3 wasn't working with the LL2 config.txt, so I created a separate config.txt file for it.

Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thatcomputerguy0101
Copy link
Contributor Author

Missing changes to https://github.com/PhotonVision/photon-image-modifier/blob/main/.github/workflows/main.yml for limelight 3

What changes? I didn't add an install script, so I think everything there still works. The LL3 script is actually quite similar to the LL3g and LL4 scripts now.

@mcm001
Copy link
Contributor

mcm001 commented Feb 2, 2026

Oh you're so right. No changes to the workflow.

I'm curious why we have different limelight and LL3 scripts -- they seem largely similar? -- but that's a topic for later.

@thatcomputerguy0101
Copy link
Contributor Author

The limelight script (and config.txt) probably need to be reworked, but I'm concerned about doing that mid-season.

Copy link
Contributor

@crschardt crschardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work until we can get the config file location upstreamed.

@mcm001 mcm001 enabled auto-merge (squash) February 2, 2026 01:58
@mcm001 mcm001 disabled auto-merge February 2, 2026 01:58
@mcm001 mcm001 merged commit 47487f7 into PhotonVision:main Feb 2, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants