Skip to content

Allow users to install any release via install.sh#49

Merged
crschardt merged 9 commits intoPhotonVision:mainfrom
crschardt:fix-incomplete-version-check
Feb 10, 2025
Merged

Allow users to install any release via install.sh#49
crschardt merged 9 commits intoPhotonVision:mainfrom
crschardt:fix-incomplete-version-check

Conversation

@crschardt
Copy link
Contributor

@crschardt crschardt commented Jan 27, 2025

This PR fixes several problems with the install.sh script:

  1. The script relied on the GitHub rest API to get a list of releases. The return from the API is paginated and only returns 30 items by default. The script now has an optional count argument for the -l option that allows the user to specify how many releases should be returned.
  2. More significantly, the script was using the returned list of releases to determine if a release is available. Since the list was truncated to 30 items, older releases such as the 2023.4.2 version were not seen as available. The script now checks directly with the REST API to determine if a release is available, so the pagination is no longer an issue.
  3. Parsing of options with optional arguments was not being done correctly when the short version of the option was used. This is now working correctly.
  4. Added a "Test" option that skips all commands that directly make changes to the system. This makes it easier to debug the script without risking making unwanted changes.
  5. The script used a pretty restrictive filter for which releases to list and it wouldn't allow users to install "Dev" or "rc" releases. The filter is now much less restrictive.
  6. The script now installs the correct jammy repository for Ubuntu 24.04 on x86 systems.

NOTE: Raspberry Pi images include libcamera-dev/stable 0.4.0+rpt20250127-3. They will only work for PhotonVision jars that include libcameraDriverVersion = v2025.0.4.

Documentation update: PhotonVision/photonvision#1746

@crschardt crschardt marked this pull request as ready for review January 27, 2025 00:45
@crschardt crschardt changed the title Fix checking for releases Allow users to install any release via install.sh Jan 27, 2025
@crschardt
Copy link
Contributor Author

I tested the image on an OPi5 and it works as expected.

@crschardt
Copy link
Contributor Author

Thanks for the approval. I’m going to hold off on merging because I got funny behavior from the RPi image on first boot and I need to track down root cause. The image starts on first power up, but hangs rather than rebooting after the initial stages. After manually rebooting, the system works fine.

@crschardt crschardt merged commit 603f054 into PhotonVision:main Feb 10, 2025
13 checks passed
crschardt added a commit to PhotonVision/photonvision that referenced this pull request Feb 10, 2025
samdev-7 pushed a commit to Earl-Of-March-FRC/photonvision that referenced this pull request Feb 16, 2025
mcm001 pushed a commit to PhotonVision/photonvision that referenced this pull request Oct 21, 2025
## Description

Adds support for building images for the Luma P1. This bumps the image
modifier pin to v2025.0.4. This pulls in:

* Allow users to install any release via install.sh by @crschardt in
PhotonVision/photon-image-modifier#49
* Exit install script if run on systemcore by @crschardt in
PhotonVision/photon-image-modifier#58
* Fix --list-versions in install.sh by @crschardt in
PhotonVision/photon-image-modifier#59
* Remove large folders of firmware that (probably) isn't needed by
@crschardt in
PhotonVision/photon-image-modifier#41
* Cancel in progress runs by @spacey-sooty in
PhotonVision/photon-image-modifier#65
* Add limelight 4 support by @spacey-sooty in
PhotonVision/photon-image-modifier#52

**Full Changelog**:
PhotonVision/photon-image-modifier@v2025.0.3...v2025.0.4


## Meta

Merge checklist:
- [x] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [x] The description documents the _what_ and _why_
- [ ] If this PR changes behavior or adds a feature, user documentation
is updated
- [ ] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible
with settings back to v2025.3.2
- [ ] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added
spacey-sooty pushed a commit to spacey-sooty/photonvision that referenced this pull request Dec 22, 2025
## Description

Adds support for building images for the Luma P1. This bumps the image
modifier pin to v2025.0.4. This pulls in:

* Allow users to install any release via install.sh by @crschardt in
PhotonVision/photon-image-modifier#49
* Exit install script if run on systemcore by @crschardt in
PhotonVision/photon-image-modifier#58
* Fix --list-versions in install.sh by @crschardt in
PhotonVision/photon-image-modifier#59
* Remove large folders of firmware that (probably) isn't needed by
@crschardt in
PhotonVision/photon-image-modifier#41
* Cancel in progress runs by @spacey-sooty in
PhotonVision/photon-image-modifier#65
* Add limelight 4 support by @spacey-sooty in
PhotonVision/photon-image-modifier#52

**Full Changelog**:
PhotonVision/photon-image-modifier@v2025.0.3...v2025.0.4


## Meta

Merge checklist:
- [x] Pull Request title is [short, imperative
summary](https://cbea.ms/git-commit/) of proposed changes
- [x] The description documents the _what_ and _why_
- [ ] If this PR changes behavior or adds a feature, user documentation
is updated
- [ ] If this PR touches photon-serde, all messages have been
regenerated and hashes have not changed unexpectedly
- [ ] If this PR touches configuration, this is backwards compatible
with settings back to v2025.3.2
- [ ] If this PR touches pipeline settings or anything related to data
exchange, the frontend typing is updated
- [ ] If this PR addresses a bug, a regression test for it is added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants