Skip to content

Conversation

Gold856
Copy link
Collaborator

@Gold856 Gold856 commented Aug 8, 2025

Description

This fixes a bug where the library would always be reported as loaded, causing isSupported to throw an exception if the library wasn't able to be loaded, which also caused start up issues when the library failed to load.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner August 8, 2025 22:57
@Gold856 Gold856 marked this pull request as draft August 8, 2025 22:57
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Aug 8, 2025
@Gold856
Copy link
Collaborator Author

Gold856 commented Aug 8, 2025

Needs testing.

@Gold856 Gold856 force-pushed the fix-libcamerajniloader branch from 0b6a951 to 717fbf6 Compare August 21, 2025 03:37
@samfreund
Copy link
Member

Is this ready to be merged, sans testing? If so, let's mark it as ready for review.

@Gold856 Gold856 marked this pull request as ready for review August 22, 2025 13:37
@samfreund
Copy link
Member

LGTM sans testing. I gotta figure out my new setup first tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Things relating to photon-core and photon-server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants