Fix OV9281 resolution options when libcamera #2100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backend
spacey-sooty
force-pushed
the
libcamera-ov9281-res-fix
branch
from
5738f81 to
516cac2
Compare
|
Where do these new magic FPS numbers come from? Is there a data sheet you can link? |
https://www.ovt.com/wp-content/uploads/2022/01/OV9281-OV9282-PB-v1.3-WEB.pdf |
Resolves PhotonVision#2087 Signed-off-by: Jade Turner <[email protected]>
spacey-sooty
force-pushed
the
libcamera-ov9281-res-fix
branch
from
516cac2 to
d17649f
Compare
|
That was more a gentle poke to link that in the code was all :) ty |
|
Oh yeah I can do that |
Signed-off-by: Jade Turner <[email protected]>
Gold856
requested changes
Sep 17, 2025
photon-core/src/main/java/org/photonvision/vision/camera/csi/LibcameraGpuSettables.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jade Turner <[email protected]>
spacey-sooty
commented
Sep 17, 2025
| videoModes.put(2, new FPSRatedVideoMode(PixelFormat.kUnknown, 640, 480, 65, 90, .39)); | ||
| videoModes.put(3, new FPSRatedVideoMode(PixelFormat.kUnknown, 1280, 800, 60, 60, 1)); | ||
| // Taken from https://www.ovt.com/wp-content/uploads/2022/01/OV9281-OV9282-PB-v1.3-WEB.pdf | ||
| videoModes.put(0, new FPSRatedVideoMode(PixelFormat.kUnknown, 640, 400, 240, 240, 1)); |
There was a problem hiding this comment.
Need to test this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2087
Values are taken from the datasheet and have been tested on the LL4 (Todo)
Meta
Merge checklist: