Rebase main on master #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix unit test CMake bug and small typos * Fix bug when building with ros when testing is off * Revert commit and eliminate BUILD_TESTING check
* extend JSOn convertion to include vectors * fixing comments
Signed-off-by: Leander Stephen D'Souza <[email protected]>
Duuuude
Signed-off-by: redvinaa <[email protected]>
This reverts commit 0ee319b.
…ut<T>` to convert `vector<BT::Any>` type to `vector<T>` * Support vector<Any> -> vector<typename T::value_type> conversion Don't check port type alignment for vector<Any> * Convert vector to vector<Any> before placing on the blackboard Also update checks to allow mismatch when a port was declared as a vector<T> and we have an input port that takes it in as a vector<Any> * Update include/behaviortree_cpp/blackboard.h Co-authored-by: Nathan Brooks <[email protected]> * Fix formatting with pre-commit * Add unit test passing a vector through ports --------- Co-authored-by: Nathan Brooks <[email protected]>
This aligns with how custom types are represented by the JsonExporter. * Update both toJson & fromJson functions in the JsonExporter * Add & update tests Co-authored by: David Sobek <[email protected]>
Signed-off-by: Paul Gesel <[email protected]>
Closed
|
@dyackzan can we work on fixing up this PR so I can get my tests on top? |
dyackzan
force-pushed
the
rebase-main-on-master
branch
5 times, most recently
from
a84c25b to
bd5ceea
Compare
dyackzan
force-pushed
the
rebase-main-on-master
branch
from
bd5ceea to
5d316db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/PickNikRobotics/moveit_pro/issues/13668