Skip to content

Conversation

@sinaaghli
Copy link

@sinaaghli sinaaghli commented Jul 11, 2025

when running mock_sim example the admitance controller is unstable. the reason is that /force_torque_sensor_broadcaster/wrench is publishing all NaNs .
this PR removes the FTS sensor from ros2_control and as a result admitance controller is working as expected

Closes https://github.com/PickNikRobotics/moveit_pro/issues/13267

@sinaaghli sinaaghli requested review from marioprats and pac48 July 11, 2025 19:41
@sinaaghli sinaaghli self-assigned this Jul 11, 2025
Copy link

@marioprats marioprats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sinaaghli !
This LGTM.
As a side request, could you please update the JTAC code to protect it against NaN forces? Looks like the semantic_components::ForceTorqueSensor can report NaNs in some cases, so we need to protect the controller against that.
Feel free to add here or create a separate issue / PR for it.
Thanks!

@marioprats
Copy link

@sinaaghli you may have to rebase on the latest main to fix the issue with CI

@sinaaghli
Copy link
Author

@sinaaghli you may have to rebase on the latest main to fix the issue with CI

Hello @marioprats thanks for the review, sorry I am responding so late, for sure, I will rebase before i merge the branch, and also will check for NaNs. I will check back with you before I'm ready to merge to get your approval.
Sorry, I have been focusing mostly on Fanuc as they seem to be in a rush deadline, and this fell in cracks!

@sinaaghli
Copy link
Author

@marioprats there seems to be already a safeguard around NaNs for fts here), I'm still investigating where else this migh have been breaking

@marioprats
Copy link

@marioprats there seems to be already a safeguard around NaNs for fts here), I'm still investigating where else this migh have been breaking

Converting the PR to draft while this is being investigated

@marioprats marioprats marked this pull request as draft July 24, 2025 11:10
@nbbrooks
Copy link
Member

@sinaaghli can you rebase/merge in main to trigger tests?

@shaur-k shaur-k force-pushed the fix/sinaaghli/admitance-mocksim-fts-nans branch from 1d3781d to d9b1dd6 Compare September 24, 2025 20:52
@sinaaghli sinaaghli marked this pull request as ready for review September 24, 2025 22:18
@sinaaghli sinaaghli removed the request for review from pac48 September 24, 2025 22:18
@shaur-k shaur-k merged commit 3d4f445 into main Sep 28, 2025
5 checks passed
shaur-k added a commit that referenced this pull request Sep 30, 2025
…mocksim-fts-nans

ignores the fts sensor feedback which is publishing nans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants